physlock: 0.5 -> 11-dev #29083
Merged
physlock: 0.5 -> 11-dev #29083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timor
force-pushed
the
physlock-11-dev
branch
from
348aa7f
to
eb27f52
Compare
|
Now that I created the pull request I am wondering whether adding the PAM dependency may actually be a bad thing? |
Update physlock to a more current version which supports PAM and systemd-logind. Amongst others, this should work now with the slim login manager without any additional configuration, because it does not rely on the utmp mechanism anymore.
timor
force-pushed
the
physlock-11-dev
branch
from
eb27f52
to
ae87a30
Compare
|
Thanks! Less assumption about used login-managers is a good thing, I would say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update physlock to a more current version which supports PAM and
systemd-logind. Amongst others, this should work now with the slim
login manager without any additional configuration, because it does
not rely on the utmp mechanism anymore.
Motivation for this change
The old physlock version did not support PAM, and relied on the session manager
creating utmp entries. This version supports getting the necessary information via
systemd-logind, so that it works from X as well as the terminals out of the box.
Things done
Updated Package source to new version.
Changed service file to add the corresponding PAM service
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)