Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copyq: 2.9.0 -> 3.0.3 #28534

Merged
merged 1 commit into from
Aug 25, 2017
Merged

copyq: 2.9.0 -> 3.0.3 #28534

merged 1 commit into from
Aug 25, 2017

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Aug 24, 2017

Update CopyQ to 3.0.3. This required a change to qt5 and a cmake patch (reported upstream) like the one for kdenlive #26160. Added an explicit qtwebkit dependency which optionally can be turned off (2.9.0 had qtwebkit support by default since it used qt4).

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@hedning
copyq: 2.9.0 -> 3.0.3
be8e1b9 
- Updated to use qt5
- Added a required cmake patch (like this one for kdenlive
  NixOS#26160)
- Optional, by default true, dependency on qtwebkit
@Mic92 Mic92 merged commit 702c327 into NixOS:master Aug 25, 2017
@Mic92
Copy link
Member

Mic92 commented Aug 25, 2017

Thanks!

@hedning hedning deleted the copyq_3.0.3 branch March 1, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hedning @Mic92