Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModSecurity Connector #28544

Closed
wants to merge 0 commits into from
Closed

Add ModSecurity Connector #28544

wants to merge 0 commits into from

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Aug 24, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

];

meta = {
description = "libModSecurity";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a proper description. Also consider indicating which license is used, too.

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 25, 2017

Fixed. Please recheck pull request.

];

meta = with stdenv.lib; {
description = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more appropriate as a longDescription. The description should be only a few words at most (so that it renders nicely in a package listing).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description fixed.

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 25, 2017

Update description

@Izorkin Izorkin closed this Nov 26, 2017
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants