Add ModSecurity Connector #28544
Closed
Add ModSecurity Connector #28544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
reviewed
Aug 24, 2017
| ]; | ||
|
|
||
| meta = { | ||
| description = "libModSecurity"; |
There was a problem hiding this comment.
Please provide a proper description. Also consider indicating which license is used, too.
|
Fixed. Please recheck pull request. |
joachifm
reviewed
Aug 25, 2017
| ]; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = '' |
There was a problem hiding this comment.
This is more appropriate as a longDescription. The description should be only a few words at most (so that it renders nicely in a package listing).
|
Update description |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)