Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate doubled case in visit_cast. #5011

Merged
merged 1 commit into from Sep 20, 2017
Merged

Eliminate doubled case in visit_cast. #5011

merged 1 commit into from Sep 20, 2017

Conversation

akzhan
Copy link
Contributor

@akzhan akzhan commented Sep 20, 2017

Just minor cleanup.

@asterite asterite merged commit 0fdf721 into crystal-lang:master Sep 20, 2017
@asterite
Copy link
Member

I might consider making the compiler give an error in this case. I think it's at least safe to error a literal is repeated, maybe if a variable too. With method calls it's a bit tricky because they might have side effects (you shouldn't do that anyway, but we can't assume that)

@akzhan akzhan deleted the eliminate-doubled-case-in-visit_cast branch September 20, 2017 14:37
@asterite asterite added this to the Next milestone Sep 25, 2017
@asterite asterite mentioned this pull request Sep 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:compiler
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akzhan @asterite @RX14