Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jetbrains packages #29591

Merged
merged 9 commits into from Sep 21, 2017
Merged

Update jetbrains packages #29591

merged 9 commits into from Sep 21, 2017

Conversation

andir
Copy link
Member

@andir andir commented Sep 20, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir andir requested a review from edwtjo as a code owner September 20, 2017 11:44
@andir andir changed the title Update jetbrains Update jetbrains packages Sep 20, 2017
andir
andir commented Sep 20, 2017
View reviewed changes
pkgs/applications/editors/jetbrains/default.nix Outdated
url = "https://download.jetbrains.com/resharper/Rider-RC-${version}.tar.gz";
sha256 = "37bad69cdfcc4f297b2500a7bb673af7ef8f1fd45baa4eb2fa388d2c4bcb41ee"; /* updated by script */
url = "https://download.jetbrains.com/resharper/JetBrains.Rider-${version}.tar.gz";
sha256 = ""; /* updated by script */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw this, should probably be fixed.. I thought I did so already..

@NeQuissimus NeQuissimus mentioned this pull request Sep 21, 2017
Merged
8 tasks
@NeQuissimus NeQuissimus merged commit 5facaca into NixOS:master Sep 21, 2017
@NeQuissimus NeQuissimus mentioned this pull request Sep 21, 2017
Closed
8 tasks
@andir andir deleted the update-jetbrains branch September 21, 2017 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @NeQuissimus