Let HTML.escape only escape &<>"' #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For documentation purposes
…On Wed, Sep 20, 2017 at 10:16 AM, Benoit de Chezelles < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/html.cr
<#5012 (comment)>:
> #
# ```
# HTML.unescape("Crystal & You") # => "Crystal & You"
# ```
- def self.unescape(string : String)
+ def self.unescape(string : String) : String
Why do you explicitly specify the return type here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5012 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMx28yMlJgy_fKRMies1gn0pWeir8Uoks5skRAzgaJpZM4Pd18n>
.
|
|
Yes, it's original idea just to rollback bad change :) |
RX14
approved these changes
Sep 21, 2017
This was referenced Jan 1, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3233
According to OWSAP these are the only ones that should be escaped. Well, actually, they also recommend escaping
/. However, Ruby, Python and Go just escape these, so I think it's pretty safe if we do the same thing.About
unescape: maybe more (all) named chars should be unescaped, but it's out of the scope of this PR.This basically undoes #2175, which was a mistake.