Refactor Socket::process into Socket::would_accept and Socket::process_accepted #38
+214
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Currently the
process
methods both check whatever the packet can be processed by the socket and do the processing. While it makes sense at the moment, the eventual adoption of a packet dispatching mechanism will make the checks optional in some configurations, thus it's beneficial to split the methods in two preemptively. As a side effect, the refactoring will allow us to get rid of theError::Rejected
error, which doesn't represent a problem with a packet or a socket, but serves as a marker of a failed packet dispatching.Solution: Split the
process
methods intowould_accept
andprocess_accepted
.Changes introduced by this pull request:
TcpSocket::process
,UdpSocket::process
andRawSocket::process
have been refactored.Error::Rejected
has been removed as not needed anymore.Other:
This PR is a part of #19 effort.