Update vdirsyncer (+ one dep), khard #29107

matthiasbeyer · 2017-09-08T08:40:36Z

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

FRidh · 2017-09-08T08:53:28Z

pkgs/top-level/python-packages.nix

@@ -2772,12 +2772,12 @@ in {
  };

  click-log = buildPythonPackage rec {


While you're at it, please move this expression to a separate file in python-modules/

teto · 2017-09-21T03:21:28Z

Didn't see this PR and I had prepared one myself. Could you pick this hunk please teto@fcbbf45#diff-fa94f0db0527b004ae3809fa214083a0R27 ? I am afraid the locale might leak in a normal environement when it's only needed for the tests.

matthiasbeyer · 2017-10-14T20:40:22Z

@teto I guess your hunk is outdated.

matthiasbeyer · 2017-10-14T20:40:59Z

@FRidh updated for latest versions.

teto · 2017-10-15T04:19:41Z

I meant changing the LC_ALL variable to the test part where it's used:
teto@fcbbf45#diff-fa94f0db0527b004ae3809fa214083a0L26 . I am worried about side effects (though there may be none ?! like does the LC_ALL get exported in nix-shell ?)

teto · 2017-10-18T09:01:46Z

Looking forward to this one
The failures on darwin are locale related. Not sure how it works there, the locale seems missing

nix/store/ab2iwb8ks5day43sw0580hdf54nfa4pv-bash-4.4-p12/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf8): No such file or directory

============================= test session starts ==============================

platform darwin -- Python 3.6.2, pytest-3.2.1, py-1.4.34, pluggy-0.4.0

rootdir: /private/tmp/nix-build-vdirsyncer-0.16.3.drv-0/vdirsyncer-0.16.3, inifile: setup.cfg

plugins: hypothesis-3.11.1, localserver-0.3.7, subtesthack-0.1.1

collected 486 items

tests/storage/test_filesystem.py ..............................................sss......ss.......

tests/storage/test_http.py .....

tests/storage/test_http_with_singlefile.py ......................................sssssss....sssss.ss

tests/storage/test_memory.py ......................................sssssss....sss...ss

tests/storage/test_singlefile.py ....................................................ss.ss

tests/storage/dav/test_caldav.py ssssssssssssssssssssssssssssssssssssssssssssssssssssss

tests/storage/dav/test_carddav.py ssssssssssssssssssssssssss

tests/storage/dav/test_main.py .................................

tests/system/cli/test_config.py .........

tests/system/cli/test_discover.py FFFFF

tests/system/cli/test_fetchparams.py F

tests/system/cli/test_repair.py FFFFF

tests/system/cli/test_sync.py FFFFFFFFsFFFFFFFFFFF

tests/system/cli/test_utils.py ..

tests/system/utils/test_main.py .....

tests/unit/test_exceptions.py .

tests/unit/test_metasync.py .........

tests/unit/test_repair.py ..........

tests/unit/cli/test_config.py .

tests/unit/cli/test_discover.py ......

tests/unit/cli/test_fetchparams.py .........

tests/unit/sync/test_status.py .

tests/unit/sync/test_sync.py ...............................

tests/unit/utils/test_vobject.py ..................

=================================== FAILURES ===================================

____________________________ test_discover_command _____________________________

tests/system/cli/test_discover.py:38: in test_discover_command

    assert not result.exception

E   assert not FileNotFoundError(2, "No such file or directory: 'locale'")

E    +  where FileNotFoundError(2, "No such file or directory: 'locale'") = <Result FileNotFoundError(2, "No such file or directory: 'locale'")>.exception

___________________ test_discover_different_collection_names ___________________

tests/system/cli/test_discover.py:91: in test_discover_different_collection_names

    assert not result.exception

E   assert not FileNotFoundError(2, "No such file or directory: 'locale'")

E    +  where FileNotFoundError(2, "No such file or directory: 'locale'") = <Result FileNotFoundError(2, "No such file or directory: 'locale'")>.exception

__________________________ test_discover_direct_path ___________________________

tests/system/cli/test_discover.py:134: in test_discover_direct_path

    assert not result.exception

E   assert not FileNotFoundError(2, "No such file or directory: 'locale'")

E    +  where FileNotFoundError(2, "No such file or directory: 'locale'") = <Result FileNotFoundError(2, "No such file or directory: 'locale'")>.exception

__________________ test_null_collection_with_named_collection __________________

tests/system/cli/test_discover.py:161: in test_null_collection_with_named_collection

    assert not result.exception

E   assert not FileNotFoundError(2, "No such file or directory: 'locale'")

E    +  where FileNotFoundError(2, "No such file or directory: 'locale'") = <Result FileNotFoundError(2, "No such file or directory: 'locale'")>.exception

FRidh · 2017-10-18T11:50:31Z

pkgs/development/python-modules/click-log/default.nix

+  version = "0.2.0";
+  name = "click-log-${version}";
+
+  src = fetchurl {


matthiasbeyer · 2017-11-08T18:46:52Z

Outdated.

teto · 2017-11-09T01:36:42Z

Are you going to push an updated one ? was waiting for this one to solve a google calendar + vdirsyncer problem

matthiasbeyer · 2017-11-09T08:08:09Z

@teto was already updated in #31041

matthiasbeyer requested a review from FRidh as a code owner September 8, 2017 08:40

FRidh reviewed Sep 8, 2017

View reviewed changes

FRidh added the 6.topic: python label Sep 8, 2017

click-log: 0.1.3 -> 0.2.0

9dff778

matthiasbeyer force-pushed the update-pim branch from 54ce1cf to 0c2615d Compare October 14, 2017 20:36

matthiasbeyer added 3 commits October 14, 2017 22:40

vdirsyncer: 0.15.0 -> 0.16.3

2b8e494

click-log: Move to python-modules

29fb80d

khal: 0.9.7 -> 0.9.8

327e8d3

matthiasbeyer force-pushed the update-pim branch from 0c2615d to 327e8d3 Compare October 14, 2017 20:42

FRidh reviewed Oct 18, 2017

View reviewed changes

pkgs/development/python-modules/click-log/default.nix

version = "0.2.0";

name = "click-log-${version}";

src = fetchurl {

Copy link

Member

FRidh Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi

matthiasbeyer closed this Nov 8, 2017

matthiasbeyer deleted the update-pim branch November 8, 2017 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update vdirsyncer (+ one dep), khard #29107

Update vdirsyncer (+ one dep), khard #29107

matthiasbeyer commented Sep 8, 2017

FRidh Sep 8, 2017

teto commented Sep 21, 2017

matthiasbeyer commented Oct 14, 2017

matthiasbeyer commented Oct 14, 2017

teto commented Oct 15, 2017

teto commented Oct 18, 2017

FRidh Oct 18, 2017

matthiasbeyer commented Nov 8, 2017

teto commented Nov 9, 2017

matthiasbeyer commented Nov 9, 2017

		@@ -2772,12 +2772,12 @@ in {
		};

		click-log = buildPythonPackage rec {

Update vdirsyncer (+ one dep), khard #29107

Update vdirsyncer (+ one dep), khard #29107

Conversation

matthiasbeyer commented Sep 8, 2017

Things done

FRidh Sep 8, 2017

Choose a reason for hiding this comment

teto commented Sep 21, 2017

matthiasbeyer commented Oct 14, 2017

matthiasbeyer commented Oct 14, 2017

teto commented Oct 15, 2017

teto commented Oct 18, 2017

FRidh Oct 18, 2017

Choose a reason for hiding this comment

matthiasbeyer commented Nov 8, 2017

teto commented Nov 9, 2017

matthiasbeyer commented Nov 9, 2017