Fix hw-kafka-client haskell package #29109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peti
requested changes
Sep 8, 2017
| @@ -105,6 +105,11 @@ self: super: builtins.intersectAttrs super { | |||
| configureFlags = "--extra-include-dirs=${pkgs.rdkafka}/include/librdkafka"; | |||
| }); | |||
|
|
|||
| hw-kafka-client = overrideCabal super.hw-kafka-client (drv: { | |||
| preConfigure = "sed -i -e /extra-lib-dirs/d -e /include-dirs/d -e /librdkafka/d hw-kafka-client.cabal"; | |||
There was a problem hiding this comment.
Please add a comment at the top explaining why those lines need to be deleted. Also, it would be nice to report that issue upstream (and possibly add a comment referring to that Github ticket, too).
(unit tests all pass)
peti
requested changes
Sep 8, 2017
| @@ -105,6 +105,12 @@ self: super: builtins.intersectAttrs super { | |||
| configureFlags = "--extra-include-dirs=${pkgs.rdkafka}/include/librdkafka"; | |||
| }); | |||
|
|
|||
| # library has hard coded directories that need to be removed https://github.com/NixOS/nixpkgs/pull/29109 | |||
There was a problem hiding this comment.
Mentioning the URL of this pull request here is not necessary because the git history will contain that information when the PR is merged. What would be nice, though, is to report that issue upstream and to add an URL to that upsteam bug report in that comment instead.
peti
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Needed to add rdkafka dependency
Things done
Add preConfigure step and configureFags
Built using
nix-shell -p "haskellPackages.ghcWithPackages (pkgs: [pkgs.hw-kafka-client])"build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)