Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scorched3d: fixing build with gcc6 #29101

Merged
merged 1 commit into from Sep 8, 2017
Merged

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Sep 8, 2017

Motivation for this change

fixes build with gcc6

related to #28643

Applied patch from gentoo. Still building, will confirm all works tomorrow.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@disassembler, thanks for your PR! By analyzing the history of the files in this pull request, we identified @urkud, @abbradar and @edolstra to be potential reviewers.

@globin globin changed the title scorced3d: fixing build with gcc6 scorched3d: fixing build with gcc6 Sep 8, 2017
@globin globin merged commit dc15c15 into NixOS:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants