Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hsevm: v0.3.2 -> v0.6.4 #28694

Merged
merged 1 commit into from
Aug 30, 2017
Merged

hsevm: v0.3.2 -> v0.6.4 #28694

merged 1 commit into from
Aug 30, 2017

Conversation

mbrock
Copy link
Contributor

@mbrock mbrock commented Aug 29, 2017

Motivation for this change

Features etc, but also Cabal version bound fixes to make build work.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Aug 29, 2017

Fails to build for me:

configuring hsevm-0.3.2...
Setup: Encountered missing dependencies:
brick >=0.17.2 && <0.18, vty ==5.15.*
builder for ‘/nix/store/7phd9xrzl0zl7r57ssxz25d7mc42ik4a-hsevm-0.3.2.drv’ failed with exit code 1
error: build of ‘/nix/store/7phd9xrzl0zl7r57ssxz25d7mc42ik4a-hsevm-0.3.2.drv’ failed

@mbrock
Copy link
Contributor Author

mbrock commented Aug 30, 2017

@fpletz that looks like your computer tried to build the previous version that this commit upgrades from!

@fpletz
Copy link
Member

fpletz commented Aug 30, 2017

Oh, well… I've been checking too many PRs in parallel. Sorry. :)

@fpletz fpletz merged commit dd2d140 into NixOS:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbrock @fpletz