Replace shelling out to fxload with CypressFX.FX2 calls #67
Conversation
| try: | ||
| return self.dev.tty() | ||
| except AttributeError: | ||
| return None | ||
|
|
||
|
|
||
| def load_fx2(board, mode=None, filename=None, verbose=False): |
There was a problem hiding this comment.
Can we move the libusb version of load_fx2 into libusb.py and load_fx2 which uses the binary into lsusb.py?
|
So I can confirm this works now you have the stop CPU logic around the right way. Could we refactor this code a little? I'd like your new load_fx2 code to be part of the libusb.py and the old code path which uses the fxload command be part of the lsusb.py. We should then have an argument to modeswitch which tells it which backend to use (lsusb or libusb). Libusb will be the only option for Mac / Windows people but I would like to keep the lsusb option open for Linux people. If you don't think you'll have time to do this refactor soon, I'll try and take a look at it. |
|
I'm traveling at the moment and probably won't have time to look at this until next week. |
|
@John-K -- Just a friendly ping, I think we should try and get this merged ASAP? If you don't have time to do it yourself I will take a look at it... |
Per IRC request, addresses #9
@mithro I don't have a setup here to test this and am unfamiliar with Conda, would appreciate any small fixes (such as the import line for CypressFX?) that may be needed to get this working.
If this proves useful, I'll work to get CypressFX submitted to pypi to remove the github pip install from Makefile.