dia: enable on darwin, 0.97 -> 2017-06-22 #28776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapper was introduced as workaround for NixOS#1691. The original bug was present in 0.97.2 but was fixed in 0.97.3.
7c6f434c
reviewed
Aug 31, 2017
| name = "dia-${minVer}.3"; | ||
| minVer = "0.97"; | ||
| name = "dia-${version}"; | ||
| version = "2017-06-22"; |
There was a problem hiding this comment.
I think it is recommended to write something like 0.97.3.20170622 just in case there is ever a 0.97.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Releases of Dia have stopped in 2014, but there are some ongoing improvements in git. Darwin support is already available in 0.97.3, but there is a bug with colors that is fixed in master.
I also found that "persistence" bug was fixed between 0.97.2 and 0.97.3.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)cc @7c6f434c