Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-workbench: fix build with gcc6 #28786

Merged
merged 1 commit into from
Aug 31, 2017
Merged

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 31, 2017

Motivation for this change

This fixes the build of mysql-workench (see #28643).

An update is available (6.3.9) but it will require more work to get it in nixpkgs (gtk3 migration). I leave it for later work.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 added this to the 17.09 milestone Aug 31, 2017
@Mic92 Mic92 merged commit a2bb174 into NixOS:master Aug 31, 2017
@lsix lsix deleted the fix-mysql-workbench branch August 22, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants