Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpPackages.pcs: init at 1.3.3 #28484

Merged
merged 1 commit into from
Aug 25, 2017
Merged

phpPackages.pcs: init at 1.3.3 #28484

merged 1 commit into from
Aug 25, 2017

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Adds php pcs extension. Needed for a following PR when adding php couchbase extension to nixpkgs.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Gerschtli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @deeky666, @shlevy and @pSub to be potential reviewers.

@Mic92 Mic92 changed the title php pcs: init at 1.3.3 phpPackages.pcs: init at 1.3.3 Aug 25, 2017
@Mic92 Mic92 merged commit 2da2cf3 into NixOS:master Aug 25, 2017
@Mic92
Copy link
Member

Mic92 commented Aug 25, 2017

Thanks!

@Gerschtli Gerschtli deleted the add/php-pcs branch August 25, 2017 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants