Bcolz init at 1.1.2 #29627

gabesoft · 2017-09-21T03:35:18Z

Motivation for this change

Added the bcolz package

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

FRidh · 2017-09-21T06:13:22Z

pkgs/top-level/python-packages.nix

@@ -3677,6 +3677,24 @@ in {
    };
  };

+  bcolz = buildPythonPackage rec {


this needs to be moved to python-modules/bcolz/default.nix as explained in the header of this file

FRidh · 2017-09-21T06:13:27Z

pkgs/top-level/python-packages.nix

+  bcolz = buildPythonPackage rec {
+    name = "bcolz-1.1.2";
+
+    src = pkgs.fetchurl {


Thanks, that's better. Fixed.

FRidh · 2017-09-21T06:13:37Z

pkgs/top-level/python-packages.nix

+    };
+
+    propagatedBuildInputs = with self; [ numpy mock ];
+    buildInputs = with self; [ numpy ];


No need if already a propagatedBuildInput

vyp · 2017-09-21T06:36:11Z

pkgs/top-level/python-packages.nix

+    buildInputs = with self; [ numpy ];
+
+    meta = {
+      description = "A columnar data container that can be compressed.";


Description should have no period at the end. https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

Removed the period

FRidh · 2017-09-23T07:03:32Z

$ nix-build -A python3.pkgs.bcolz
these derivations will be built:
  /nix/store/v21c4vg3l2xdxgng7nbi9vkc35cxx4sh-python3.6-bcolz-1.1.2.drv
building path(s) '/nix/store/8r3gnr1y7fhpdgrhzyjlvg66ifcs81kq-python3.6-bcolz-1.1.2'
building '/nix/store/v21c4vg3l2xdxgng7nbi9vkc35cxx4sh-python3.6-bcolz-1.1.2.drv'...
unpacking sources
unpacking source archive /nix/store/qdl77bwvb2ryzcxgdqprxwr6k2ra4vqi-bcolz-1.1.2.tar.gz
source root is bcolz-1.1.2
/nix/store/j1ly0zzpnzb8y8ry6k4vi4prk8vwq233-set-source-date-epoch-to-latest.sh: line 7: warning: command substitution: ignored null byte in input
setting SOURCE_DATE_EPOCH to timestamp 1486026331 of file bcolz-1.1.2/setup.cfg
patching sources
configuring
building
Download error on https://pypi.python.org/simple/setuptools-scm/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'setuptools-scm' (maybe misspelled?)
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for setuptools-scm>1.5.4
SSE2 detected
AVX2 detected
Traceback (most recent call last):
  File "nix_run_setup.py", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
  File "setup.py", line 234, in <module>
    cmdclass=LazyCommandClass(),
  File "/nix/store/9y5qyjs1s155vnwlxprg626xp19bfvv6-python3-3.6.2/lib/python3.6/distutils/core.py", line 108, in setup
    _setup_distribution = dist = klass(attrs)
  File "/nix/store/xdas067jb01m1lwf5pmnxgmsi92jg926-python3.6-bootstrapped-pip-9.0.1/lib/python3.6/site-packages/setuptools/dist.py", line 335, in __init__
    self.fetch_build_eggs(attrs['setup_requires'])
  File "/nix/store/xdas067jb01m1lwf5pmnxgmsi92jg926-python3.6-bootstrapped-pip-9.0.1/lib/python3.6/site-packages/setuptools/dist.py", line 456, in fetch_build_eggs
    replace_conflicting=True,
  File "/nix/store/xdas067jb01m1lwf5pmnxgmsi92jg926-python3.6-bootstrapped-pip-9.0.1/lib/python3.6/site-packages/pkg_resources/__init__.py", line 863, in resolve
    replace_conflicting=replace_conflicting
  File "/nix/store/xdas067jb01m1lwf5pmnxgmsi92jg926-python3.6-bootstrapped-pip-9.0.1/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1141, in best_match
    return self.obtain(req, installer)
  File "/nix/store/xdas067jb01m1lwf5pmnxgmsi92jg926-python3.6-bootstrapped-pip-9.0.1/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1153, in obtain
    return installer(requirement)
  File "/nix/store/xdas067jb01m1lwf5pmnxgmsi92jg926-python3.6-bootstrapped-pip-9.0.1/lib/python3.6/site-packages/setuptools/dist.py", line 522, in fetch_build_egg
    return cmd.easy_install(req)
  File "/nix/store/xdas067jb01m1lwf5pmnxgmsi92jg926-python3.6-bootstrapped-pip-9.0.1/lib/python3.6/site-packages/setuptools/command/easy_install.py", line 666, in easy_install
    raise DistutilsError(msg)
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('setuptools-scm>1.5.4')
builder for '/nix/store/v21c4vg3l2xdxgng7nbi9vkc35cxx4sh-python3.6-bcolz-1.1.2.drv' failed with exit code 1
error: build of '/nix/store/v21c4vg3l2xdxgng7nbi9vkc35cxx4sh-python3.6-bcolz-1.1.2.drv' failed

Please test with sandboxing.

gabesoft · 2017-09-23T18:04:21Z

Please test with sandboxing

Thanks, fixed. Tested for python27 & python35

FRidh · 2017-09-26T07:30:51Z

pkgs/development/python-modules/bcolz/default.nix

+    version = "1.1.2";
+    name = "${pname}-${version}";
+
+    disabled = !(isPy35 || isPy27);


surely it works on other interpreter versions as well?

You're right. Removed.

FRidh · 2017-09-26T07:30:57Z

pkgs/development/python-modules/bcolz/default.nix

+{ stdenv, buildPythonPackage, fetchPypi, numpy, mock, setuptools_scm, isPy27, isPy35 }:
+
+buildPythonPackage rec {
+    pname = "bcolz";


2 space indentation

FRidh · 2017-09-26T07:31:11Z

pkgs/development/python-modules/bcolz/default.nix

+    };
+
+    doCheck = isPy27;
+    propagatedBuildInputs = [ numpy mock setuptools_scm ];


is setuptools_scm needed during runtime?

moved it to buildInputs

FRidh · 2017-09-26T07:31:24Z

pkgs/development/python-modules/bcolz/default.nix

+      sha256 = "0ws0b9p1r4gcxic7fm8clm2q2ily3bd6i4giczw4s6gv5ilk7ds2";
+    };
+
+    doCheck = isPy27;


why disable tests with other versions?

I could only get the tests to pass on python2

FRidh · 2017-09-26T15:17:52Z

distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('cython>=0.22')

gabesoft requested a review from FRidh as a code owner September 21, 2017 03:35

FRidh requested changes Sep 21, 2017

View reviewed changes

vyp reviewed Sep 21, 2017

View reviewed changes

gabesoft force-pushed the bcolz-package branch from 2bb5d8e to d72fa65 Compare September 22, 2017 03:02

FRidh added 2.status: work-in-progress 6.topic: python labels Sep 23, 2017

gabesoft force-pushed the bcolz-package branch from d72fa65 to 7617f68 Compare September 23, 2017 18:03

FRidh requested changes Sep 26, 2017

View reviewed changes

gabesoft force-pushed the bcolz-package branch from 7617f68 to 7231a07 Compare September 26, 2017 14:54

Bcolz init at 1.1.2

ebb5656

gabesoft force-pushed the bcolz-package branch from 7231a07 to ebb5656 Compare September 27, 2017 16:17

samueldr added the 2.status: merge conflict label Nov 11, 2018

gabesoft closed this Dec 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bcolz init at 1.1.2 #29627

Bcolz init at 1.1.2 #29627

gabesoft commented Sep 21, 2017 •

edited

FRidh Sep 21, 2017

gabesoft Sep 21, 2017

FRidh Sep 21, 2017

gabesoft Sep 21, 2017

FRidh Sep 21, 2017

gabesoft Sep 21, 2017

vyp Sep 21, 2017

gabesoft Sep 21, 2017

FRidh commented Sep 23, 2017

gabesoft commented Sep 23, 2017

FRidh Sep 26, 2017

gabesoft Sep 26, 2017

FRidh Sep 26, 2017

gabesoft Sep 26, 2017

FRidh Sep 26, 2017

gabesoft Sep 26, 2017

FRidh Sep 26, 2017

gabesoft Sep 26, 2017

FRidh commented Sep 26, 2017

Bcolz init at 1.1.2 #29627

Bcolz init at 1.1.2 #29627

Conversation

gabesoft commented Sep 21, 2017 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FRidh commented Sep 23, 2017

gabesoft commented Sep 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FRidh commented Sep 26, 2017

gabesoft commented Sep 21, 2017 •

edited