Support LLVM 4.0 postfixed versions #5013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian-based distributions allow you to install multiple versions of LLVM
in parallel, allowing you to access them individually using postfixed
`llvm-config` versions (ie `llvm-config-3.8` or `llvm-config-3.9`).
Ubuntu (Xenial) added packages for LLVM 4.0 with `-4.0` postfix (under
`llvm-4.0` package).
Crystal supports and uses 3.9 or 3.8, but no option for 4.0.
This change makes sure LLVM 4.0 is also tried first.
Before this change (with LLVM 4.0 installed):
$ make crystal
Using /usr/bin/llvm-config-3.8 [version=3.8.0]
...
$ bin/crystal --version
Using compiled compiler at `.build/crystal'
Crystal 0.23.0+177 [12ed6df] (2017-09-20)
LLVM: 3.8.0
Default target: x86_64-pc-linux-gnu
After this change (with LLVM 4.0 installed)
$ make crystal
Using /usr/bin/llvm-config-4.0 [version=4.0.0]
...
$ bin/crystal --version
Using compiled compiler at `.build/crystal'
Crystal 0.23.0+177 [12ed6df] (2017-09-20)
LLVM: 4.0.0
Default target: x86_64-pc-linux-gnu
ysbaddaden
approved these changes
Sep 21, 2017
asterite
approved these changes
Sep 21, 2017
|
@luislavena Thank you! ❤️ |
Vexatos
added a commit
to Vexatos/crystal
that referenced
this pull request
Jan 4, 2018
RX14
pushed a commit
that referenced
this pull request
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian-based distributions allow you to install multiple versions of LLVM in parallel, allowing you to access them individually using postfixed
llvm-configversions (iellvm-config-3.8orllvm-config-3.9).Ubuntu (Xenial) added packages for LLVM 4.0 with
-4.0postfix (underllvm-4.0package).Crystal supports and uses 3.9 or 3.8, but no option for 4.0.
This change makes sure LLVM 4.0 is also tried first.
Before this change (with LLVM 4.0 installed):
After this change (with LLVM 4.0 installed)
Thank you for the continuous support and work on Crystal and looking forward your comments!
❤️ ❤️ ❤️