Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginxModules.echo: v0.57 -> v0.61 #29633

Merged
merged 1 commit into from Sep 21, 2017
Merged

nginxModules.echo: v0.57 -> v0.61 #29633

merged 1 commit into from Sep 21, 2017

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Sep 21, 2017 •
edited

Motivation for this change

This fixes #29555.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vaibhavsagar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @mattbillenstein and @benley to be potential reviewers.

@Mic92 Mic92 merged commit 49d18cd into NixOS:master Sep 21, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2017 •
edited

also in 17.09 now: 3f44159

@vaibhavsagar
Copy link
Member Author

Thanks so much!

@vaibhavsagar vaibhavsagar deleted the update-nginx-echo-module branch September 21, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nginx with nginxModules.echo is broken on nixos-17.09
3 participants
@vaibhavsagar @mention-bot @Mic92