Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nifticlib: init at 2.0.0 #29613

Merged
merged 2 commits into from Sep 21, 2017
Merged

nifticlib: init at 2.0.0 #29613

merged 2 commits into from Sep 21, 2017

Conversation

bcdarwin
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

nativeBuildInputs = [ cmake ];
buildInputs = [ zlib ];

checkPhase = "ctest";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!


src = fetchurl {
url = "https://downloads.sourceforge.net/project/${pname}/${pname}/${pname}_2_0_0/${name}.tar.gz";
sha256 = "123z9bwzgin5y8gi5ni8j217k7n683whjsvg0lrpii9flgk8isd3";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a wrong hash here:

$ nix-shell --keep-going -j4 --option build-use-sandbox true -p nifticlib
these derivations will be built:
  /nix/store/wz3n6j1vpvd9ghg7fkr05g1pryc1b02n-nifticlib-2.0.0.tar.gz.drv
  /nix/store/71bin3yc2c6labb8b28cl89c56xnpm51-nifticlib-2.0.0.drv
building path(s) ‘/nix/store/c410n034lzs8jk8fl8fck3898x97j784-nifticlib-2.0.0.tar.gz’
trying https://downloads.sourceforge.net/project/nifticlib/nifticlib/nifticlib_2_0_0/nifticlib-2.0.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   280    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0
  0   274    0     0    0     0      0      0 --:--:--  0:00:03 --:--:--     0
  0   276    0     0    0     0      0      0 --:--:--  0:00:04 --:--:--     0
100 49088  100 49088    0     0   9817      0  0:00:05  0:00:05 --:--:--  236k
output path ‘/nix/store/c410n034lzs8jk8fl8fck3898x97j784-nifticlib-2.0.0.tar.gz’ has sha256 hash ‘1v9rrq9ccqbz904p3ypp0ny79djr35mlx17a4nvfkjvam1aixzis’ when ‘123z9bwzgin5y8gi5ni8j217k7n683whjsvg0lrpii9flgk8isd3’ was expected
cannot build derivation ‘/nix/store/71bin3yc2c6labb8b28cl89c56xnpm51-nifticlib-2.0.0.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/71bin3yc2c6labb8b28cl89c56xnpm51-nifticlib-2.0.0.drv’ failed
/run/current-system/sw/bin/nix-shell: failed to build all dependencies

Did you forgot to update it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Sourceforge isn't giving the same file each time ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your download link is should be different. It currently returns dynamic html. We also use
urls like url = "mirror://sourceforge/statifier/statifier-${version}.tar.gz"; for sourceforge to fallback to mirrors automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 Typo in the URL, sorry ... fixed now.

@Mic92 Mic92 merged commit 116c34a into NixOS:master Sep 21, 2017
@bcdarwin bcdarwin deleted the nifti branch March 22, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants