Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains-jdk #29634

Merged
merged 2 commits into from Sep 21, 2017
Merged

jetbrains-jdk #29634

merged 2 commits into from Sep 21, 2017

Conversation

edwtjo
Copy link
Member

@edwtjo edwtjo commented Sep 21, 2017 •
edited

Motivation for this change

Adds Jetbrains OpenJDK fork with patches aimed for a better experience when using Jetbrains's products. Original commit is the jbsdk expression from @matklad (your handle is a funny spelling of foodlover in Swedish :) from Issue #23115 and then I've added another with some minor style fixes. This PR also changes the default JDK for the jetbrains attrset and as such fixes #29151.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 21, 2017

Looks webstorm needs an update:

curl: (22) The requested URL returned error: 403 Forbidden
error: cannot download WebStorm-2017.2.2.tar.gz from any mirror
builder for ‘/nix/store/fbm001gyakixdfyk4dy4aifip065d064-WebStorm-2017.2.2.tar.gz.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/9x2wg6ixypg8308m8wg5vv53mw60kj9v-webstorm-2017.2.2.drv’: 1 dependencies couldn't be built

@NeQuissimus
Copy link
Member

NeQuissimus commented Sep 21, 2017 •
edited

@Mic92 I think that is handled in #29591

Edit: Maybe not? @edwtjo ?

Edit2: nvm, works, I just had not rebased my PR checkout

@NeQuissimus NeQuissimus merged commit 182dd6a into NixOS:master Sep 21, 2017
@bbarker bbarker mentioned this pull request Apr 11, 2018
Closed
@matklad matklad mentioned this pull request May 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trouble rendering fonts in IntelliJ when using OpenJDK from nixpkgs
4 participants
@edwtjo @Mic92 @NeQuissimus @matklad