Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapper: 0.3.3 -> 0.5.0 #29620

Merged
merged 1 commit into from Sep 22, 2017
Merged

snapper: 0.3.3 -> 0.5.0 #29620

merged 1 commit into from Sep 22, 2017

Conversation

joachifm
Copy link
Contributor

NixOS service untested, probably need to look into that before merging ...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor Author

cc @ck3d

@ck3d
Copy link
Contributor

ck3d commented Sep 21, 2017

Please run the NixOS snapper test. It should be enough.

@joachifm joachifm merged commit 456e96f into NixOS:master Sep 22, 2017
@joachifm joachifm deleted the pkg/snapper-0_5_0 branch September 22, 2017 20:49
@joachifm
Copy link
Contributor Author

Passes on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joachifm @ck3d