cc-wrapper: Use stdenvNoCC to build #29617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
requested review from
copumpkin,
edolstra and
LnL7
as code owners
Ericson2314
force-pushed
the
cc-wrapper-stdenvNoCC
branch
from
b6195d0
to
7e04d57
Compare
LnL7
approved these changes
Sep 21, 2017
Ericson2314
force-pushed
the
cc-wrapper-stdenvNoCC
branch
from
7e04d57
to
1549b37
Compare
cc-wrapper may wrap a cc-compiler, but it doesn't need one to build itself. (c.f. expand-response-params is a separate derivation.) This helps avoid cycles on the cross stuff, in addition to removing a useless dependency edge. I could have been super careful with overrides in the stdenv to avoid the mass rebuild, but I don't think it's worth it.
Ericson2314
force-pushed
the
cc-wrapper-stdenvNoCC
branch
from
1549b37
to
d349f9a
Compare
vcunat
approved these changes
Sep 26, 2017
| @@ -1,15 +1,13 @@ | |||
| { lib | |||
| , crossSystem, config | |||
| , crossSystem, config, overlays | |||
There was a problem hiding this comment.
Hmm, this was missing since 92edcb7 and noone has encountered/reported the error, I guess, as we currently only use this file for "x86_64-solaris".
vcunat
added a commit
that referenced
this pull request
Sep 26, 2017
vcunat
added a commit
that referenced
this pull request
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
cc-wrapper may wrap a C compiler, but it doesn't need one to build itself. (c.f. expand-response-params is a separate derivation.) This helps avoid cycles on the cross stuff, in addition to removing a useless dependency edge.
I could have been super careful with overrides in the stdenv to avoid the mass rebuild, but I don't think it's worth it. [If all goes well, we'll merge this with the other PRs in https://github.com/NixOS/nixpkgs/projects/8, so they'll be a mas-rebuild anyways.]
Things done
Building stdenv as part of other things. PR has more commits than it should because it depends on other PRs.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)