Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpich2: 1.4 -> 3.2 #29196

Merged
merged 1 commit into from Nov 2, 2017
Merged

mpich2: 1.4 -> 3.2 #29196

merged 1 commit into from Nov 2, 2017

Conversation

timor
Copy link
Member

@timor timor commented Sep 10, 2017

Motivation for this change

Encountered this as a dependency while trying to upgrade ParaView to a newer version.

Things done

Built locally. Did not test any of the existing packages which might depend on that.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@timor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @civodul, @dguibert and @bjornfor to be potential reviewers.

@timor timor force-pushed the mpich2-3.2 branch 2 times, most recently from 2349a3f to 7a53e08 Compare September 10, 2017 12:09
@@ -1,6 +1,6 @@
{ stdenv, fetchurl, file }:

stdenv.mkDerivation rec {
stdenv.mkDerivation rec{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental ws change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thanks for spotting. Fixed it.

@orivej orivej merged commit b9bbbb7 into NixOS:master Nov 2, 2017
@timor timor deleted the mpich2-3.2 branch November 7, 2017 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants