PyBrain: Mark as broken #29198
PyBrain: Mark as broken #29198
Conversation
It's broken on all versions of Python (I've tried 2.7, 3.4, 3.5, 3.6) I think the root cause is that PyBrain is not working with numpy >= 1.12.0 as I reported here: pybrain/pybrain#217 (The relevant release notes may be found here): https://docs.scipy.org/doc/numpy-1.12.0/release.html#compatibility-notes The PyBrain github repo does not seem very active (last commit 18 months ago, last release 3 years), so I have some doubts as to whether this will be fixed any time soon. I suppose an alternative solution could be to reintroduce the explicit dependency to numpy 1.11. But, this is not entirely trivial: in c9b4a2f, the versions 1.10, 1.11, 1.12 were folded into a single version. Also, the numpy dependency is not a direct one, but is implied via scipy
Seems plausible. I have a package of mine that I need to fix for the same reason.
In Nixpkgs we only keep a single version of a package, aside from some special cases, and therefore I am opposed to that kind of solution. In any case, even if we have multiple versions, then packages shouldn't retain a runtime-dependency on a specific version.
That's no problem. You can override the Python package set to point to an older version of |
|
@FRidh given the discussion above, could you just merge & close the PR? N.B. the branch is unfortunately off release-17.09, so closing the PR should be accompanied with a cherry-pick to master (which is the reverse of the usual workflow, sorry about that) Thanks! |
|
pushed 50d3655 and to 17.09 |
It's broken on all versions of Python (I've tried 2.7, 3.4, 3.5, 3.6)
I think the root cause is that PyBrain is not working with numpy >= 1.12.0 as I reported here:
pybrain/pybrain#217
(The relevant release notes may be found here):
https://docs.scipy.org/doc/numpy-1.12.0/release.html#compatibility-notes
The PyBrain github repo does not seem very active (last commit 18 months ago, last release 3 years),
so I have some doubts as to whether this will be fixed any time soon.
I suppose an alternative solution could be to reintroduce the explicit dependency to numpy 1.11. But,
this is not entirely trivial: in c9b4a2f, the versions 1.10, 1.11, 1.12 were folded into a single version.
Also, the numpy dependency is not a direct one, but is implied via scipy
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)