Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

znc: fix network example configuration #29170

Merged
merged 1 commit into from Sep 10, 2017
Merged

znc: fix network example configuration #29170

merged 1 commit into from Sep 10, 2017

Conversation

vaibhavsagar
Copy link
Member

s/ssl/useSSL/

Motivation for this change

The example network configuration does not accurately reflect the actual configuration because the attribute name is incorrect.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vaibhavsagar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @chexxor, @schneefux and @nocoolnametom to be potential reviewers.

@Mic92 Mic92 merged commit 4424775 into NixOS:master Sep 10, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 10, 2017

Thanks!

@vaibhavsagar vaibhavsagar deleted the fix-znc-network-example branch November 29, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @mention-bot @Mic92