znc: open firewall with configured port #29171
Conversation
The configuration doesn't currently open the configured port, which is less convenient than opening it.
|
@vaibhavsagar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @chexxor, @schneefux and @nocoolnametom to be potential reviewers. |
| @@ -350,6 +350,8 @@ in | |||
|
|
|||
| config = mkIf cfg.enable { | |||
|
|
|||
| networking.firewall.allowedTCPPorts = [ cfg.port ]; | |||
There was a problem hiding this comment.
Currently we have do not open ports automatically by convention just if the server is enabled.
Users might want to use the service, but restrict the port only for specific source ips / network interfaces or don't expose it at all. The only port we open by default is ssh.
Some services have therefor an additional property called openPorts or openFirewall in the service itself to open ports explicitly.
There was a problem hiding this comment.
That makes sense. I've added an openFirewall option like the one in the Redis configuration.
|
Thanks! |
The configuration doesn't currently open the configured port, which is
less convenient than opening it.
Motivation for this change
I was confused that my IRC client was not connecting to the port until I manually opened the port in my firewall configuration separately. I think it would be better if the ZNC configuration itself ensured the port was opened.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)