Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ofxclient and pythonPackages.osprofiler: remove argparse from requirements #29158

Merged
merged 2 commits into from Sep 10, 2017
Merged

pythonPackages.ofxclient and pythonPackages.osprofiler: remove argparse from requirements #29158

merged 2 commits into from Sep 10, 2017

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Sep 9, 2017

Since argparse module is now part of python stdlib.

Motivation for this change

Fix build failure: #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
pythonPackages.ofxclient: remove argparse from requirements
21571b7 
Since argparse module is now part of python stdlib.
@nlewo nlewo requested a review from FRidh as a code owner September 9, 2017 20:34
@nlewo
pythonPackages.osprofiler: remove argparse from requirements
e7ddd5e 
Since argparse module is now part of python stdlib.
@nlewo nlewo changed the title pythonPackages.ofxclient: remove argparse from requirements pythonPackages.ofxclient and pythonPackages.osprofiler: remove argparse from requirements Sep 9, 2017
@FRidh FRidh merged commit 6521a83 into NixOS:master Sep 10, 2017
FRidh added a commit that referenced this pull request Sep 10, 2017
@FRidh
Merge pull request #29158 from nlewo/ofxclient
45e518d 
pythonPackages.ofxclient and pythonPackages.osprofiler: remove argparse from requirements

(cherry picked from commit 6521a83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlewo @FRidh