Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coin3d: include fix for newer compilers #29159

Merged
merged 1 commit into from Sep 11, 2017
Merged

coin3d: include fix for newer compilers #29159

merged 1 commit into from Sep 11, 2017

Conversation

timor
Copy link
Member

@timor timor commented Sep 9, 2017

This manifests as a segfault in any applications that use the library.

Motivation for this change

Without this, FreeCAD just segfaults when started. Thus, this is somehow also related to #28643, since FreeCAD builds, but does not run correctly without this.

Things done

Created a patch that fixes this issue. See the comments in the commit for references.

  1. Built FreeCAD without this patch and run -> segfault
  2. Built FreeCAD and coin3d with this patch -> no segfault
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timor
coin3d: include fix for newer compilers
cf32537 
This manifests as a segfault in any applications that use the library.
@mention-bot
Copy link

@timor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @viric, @vcunat and @Fuuzetsu to be potential reviewers.

@timor
Copy link
Member Author

timor commented Sep 9, 2017

cc @viric

@Mic92
Copy link
Member

Mic92 commented Sep 11, 2017

Thanks!

@Mic92 Mic92 merged commit c3887f0 into NixOS:master Sep 11, 2017
@timor timor deleted the coin3d-sbhashentry-fix branch September 11, 2017 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timor @mention-bot @Mic92