Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nilearn: 0.2.5 -> 0.3.1 #29178

Closed
wants to merge 1 commit into from
Closed

pythonPackages.nilearn: 0.2.5 -> 0.3.1 #29178

wants to merge 1 commit into from

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Sep 10, 2017

Motivation for this change

Zero hydra failures #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo nlewo requested a review from FRidh as a code owner September 10, 2017 08:43
@nlewo
Copy link
Member Author

nlewo commented Sep 11, 2017

This test fails on Darwin and I can't debug it. Could I disable it for darwin?
disable = stdenv.isDarwin

@Mic92
Copy link
Member

Mic92 commented Sep 11, 2017

Probably just a flaky test in sklearn:

py.test -k 'not sklearn.tests.test_multioutput.test_multi_output_classification_partial_fit_parallelism`

@Mic92
Copy link
Member

Mic92 commented Sep 11, 2017

I restarted the test.

FRidh
FRidh reviewed Sep 13, 2017
View reviewed changes
pkgs/top-level/python-packages.nix
@@ -13288,15 +13288,15 @@ in {
};

nilearn = buildPythonPackage rec {
version = "0.2.5";
version = "0.3.1";
name = "nilearn-${version}";

# package seems to attempt Python 3 compatibility, but throws UnicodeDecodeError when building:
disabled = isPy3k;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still the case with 0.3.1 ?

@FRidh FRidh added this to the 17.09 milestone Sep 13, 2017
@FRidh FRidh added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 13, 2017
@disassembler
Copy link
Member

I didn't see someone had already started working on this. I did pretty much the same thing and tests pass for python 3.6 as well now. master...disassembler:nilearn

Mic92 pushed a commit that referenced this pull request Sep 15, 2017
@Mic92
nilearn: 0.2.5 -> 0.3.1
11c8804 
fixes #29178

(cherry picked from commit f8f62d5)
@Mic92 Mic92 closed this in f8f62d5 Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release.
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nlewo @Mic92 @disassembler @FRidh