Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oprofile: 1.1.0 -> 1.2.0 #29185

Merged
merged 2 commits into from Sep 10, 2017
Merged

oprofile: 1.1.0 -> 1.2.0 #29185

merged 2 commits into from Sep 10, 2017

Conversation

markus2342
Copy link
Contributor

@markus2342 markus2342 commented Sep 10, 2017

Motivation for this change

The build failed for release 17.09 . The newer version includes bug fixes when compiling with newer gcc version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Fixes build with newer gcc versions.
@mention-bot
Copy link

@markus2342, thanks for your PR! By analyzing the history of the files in this pull request, we identified @civodul, @lethalman and @vcunat to be potential reviewers.

@Mic92 Mic92 merged commit ad4f798 into NixOS:master Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants