Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.recaptcha-client: disable broken versions #29187

Merged
merged 1 commit into from Sep 11, 2017

Conversation

vanschelven
Copy link
Contributor

It seems that the recaptcha-client package is no longer maintained.

  • The latest released version (1.0.6) is from the year 2011;
  • The project page does not mention which Python versions are supported
  • The project is hosted on google code, which is discontinued, e.g. making it impossible to create an issue asking about which Python versions are supported.

I was able to successfully build with Python versions 3.3, 3.4, but not
3.5, 3.6.

Motivation for this change

The package was showing as broken on Hydra.

The package initially broke on a missing dependency on Crypto, but was broken even after that, e.g.

The package imports urllib2, but

The urllib2 module has been split across several modules in Python 3 named urllib.request and urllib.error. The 2to3 tool will automatically adapt imports when converting your sources to Python 3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

It seems that the recaptcha-client package is no longer maintained.

* The latest released version (1.0.6) is from the year 2011;
* The project page does not mention which Python versions are supported
* The project is hosted on google code, which is discontinued

I was able to succesfully build with Python versions 3.3, 3.4, but not
3.5, 3.6.
@Mic92 Mic92 merged commit a82fe0e into NixOS:release-17.09 Sep 11, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 11, 2017

Thanks!

@Mic92
Copy link
Member

Mic92 commented Sep 11, 2017

oh, this should have gone into master first.

@Mic92
Copy link
Member

Mic92 commented Sep 11, 2017

now it is.

@vanschelven vanschelven deleted the recaptcha-client branch September 11, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants