New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glusterfs glusterfind fixes cherry-pick for 17.09 #29160
Merged
fpletz
merged 4 commits into
NixOS:release-17.09
from
nh2:glusterfs-glusterfind-dirs-17.09
Sep 10, 2017
Merged
glusterfs glusterfind fixes cherry-pick for 17.09 #29160
fpletz
merged 4 commits into
NixOS:release-17.09
from
nh2:glusterfs-glusterfind-dirs-17.09
Sep 10, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Thank you. Please use |
@joachifm OK, will fix. |
(cherry picked from commit 5bc38fc)
Fixes error File "/nix/store/lxpsl84km87xpk59nai6a33ihgpfs7qr-glusterfs-3.10.2/libexec/glusterfs/glusterfind/changelog.py", line 105, in populate_pgfid_and_inodegfid file_xattrs = xattr.list(p) AttributeError: 'module' object has no attribute 'list' when using `glusterfind pre`. (cherry picked from commit 8e329da)
See: https://bugzilla.redhat.com/show_bug.cgi?id=1489610 Also add patch to correctly log stderr from remote nodes when glusterfind fails. This, too, should be removed when fixed upstream. (cherry picked from commit e7325f8)
This fixes: Traceback (most recent call last): File "/nix/store/7f9arl3f9xyj8sm05mkanh2mlp217192-glusterfs-3.10.2/libexec/glusterfs/glusterfind/changelog.py", line 22, in <module> import libgfchangelog File "/nix/store/7f9arl3f9xyj8sm05mkanh2mlp217192-glusterfs-3.10.2/libexec/glusterfs/glusterfind/libgfchangelog.py", line 21, in <module> libgfc = CDLL("libgfchangelog.so", use_errno=True, mode=RTLD_GLOBAL) File "/nix/store/nlyr5ankhi7yvva8zndi718zj37js270-python-2.7.13-env/lib/python2.7/ctypes/__init__.py", line 362, in __init__ self._handle = _dlopen(self._name, mode) OSError: libgfchangelog.so: cannot open shared object file: No such file or directory Connection to 10.0.0.2 closed. when running `glusterfind pre`. Done by setting PYTHONPATH/LD_LIBRARY_PATH as for the other Python scripts. (cherry picked from commit abc96aa)
nh2
force-pushed
the
glusterfs-glusterfind-dirs-17.09
branch
from
September 9, 2017 21:01
1e5bf25
to
e75b307
Compare
@joachifm Done. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Cherry-pick of #29071.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)CC @bachp @joachifm