Replace babel es2015 preset with env, add babel-runtime #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant as a replacement for es2015 etc. and offers numerous advantages. See https://babeljs.io/docs/plugins/preset-env/#usage for details.
Allows us to use async/await/generator functions, among other things. See http://babeljs.io/docs/plugins/transform-runtime/. File size changes (all minified): with runtime common - 812K edit - 268K without runtime common - 772K edit - 264K
|
The |
yvanzo
approved these changes
Sep 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The env preset is intended to replace es2015, and is better for us since we can simply specify which browsers we're targeting in .babelrc, and it'll perform the correct transformations automatically (based on the features supported in those browsers).
babel-runtime increases the size of our JS a bit (see the commit for details), but allows us to use async + await, which are essential to sanely work with promises.