Upgrade javascript dependencies #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output of `npm outdated`. I left react, jquery, lodash, and highcharts because they were a major version upgrade. Tested by running gulp and checking the dataset editor/viewer pages.
|
I'll download and build tomorrow or the day after, but do we not have Jenkins or Travis for AB? |
|
We used to have Jenkins on ci.metabrainz.org, but I don't know if this is correctly connected to github any more. I previously had a habit of not using travis because of the github permissions that it used to require, but I believe that this is now fixed (and we use it for LB anyway). Feel free to propose a patch to enable it and work with @zas to get it enabled. |
|
I'd like to do the travis setup after the docker PR #234 gets merged, I'll build this and test manually. |
paramsingh
approved these changes
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on output of
npm outdated. I left react, jquery, lodash, and highchartsbecause they were a major version upgrade. Tested by running gulp
and checking the dataset editor/viewer pages.