Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unbound: 1.6.5 -> 1.6.6 #29612

Merged
merged 1 commit into from Sep 21, 2017
Merged

unbound: 1.6.5 -> 1.6.6 #29612

merged 1 commit into from Sep 21, 2017

Conversation

joachifm
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 20, 2017

Builds quite a few packages. Staging?

@joachifm
Copy link
Contributor Author

Hm, I seem to recall it had been decoupled from gnutls (or the other way around, really) but maybe I'm misremembering. Or perhaps there's a different rebuild trigger I'm just not aware of. In any case, I'm happy to change the target to staging.

@Mic92
Copy link
Member

Mic92 commented Sep 20, 2017

It wants to rebuild 4108 packages on my system.

fpletz
fpletz approved these changes Sep 20, 2017
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This minor update contains bugfixes so we should backport it to 17.09.

I decoupled unbound and gnutls a few months ago but reintroduced it along with some other changes (dns-root-data addition). Libunbound is used in gnutls for DANE support. I think we should support that. It is a big rebuild but not that much. Staging is probably best.

@fpletz fpletz added this to the 17.09 milestone Sep 20, 2017
@vcunat vcunat changed the base branch from master to staging September 21, 2017 19:09
@vcunat vcunat merged commit c41af35 into NixOS:staging Sep 21, 2017
vcunat added a commit that referenced this pull request Sep 21, 2017
@vcunat
Merge #29612: unbound: 1.6.5 -> 1.6.6
e151230
vcunat added a commit that referenced this pull request Sep 21, 2017
@vcunat
Merge #29612: unbound: 1.6.5 -> 1.6.6
1c6357c 
(cherry picked from commit e151230)
@joachifm
Copy link
Contributor Author

@vcunat thank you :)

@joachifm joachifm deleted the pkg/unbound-1_6_6 branch September 21, 2017 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joachifm @Mic92 @fpletz @vcunat