erlang: introduce "no X" variation #29603
Conversation
|
@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gleber, @LnL7 and @ankhers to be potential reviewers. |
There was a problem hiding this comment.
I am unsure if this is the right way to mark a package as a headless it in nixpkgs, but the code itself LGTM.
One thing we might consider is drop _odbc and _javac versions and keep normal, odbc+javac and a nox versions only. We have so many erlangs which needs to be built by Hydra, so that it seems suboptimal. I'll leave this decision to someone knowing nixpkgs ecosystem better. @LnL7, @cleverca22, any thoughts?
|
Didn't I get rid of all of the top-level erlang variants except for the default version? |
pkgs/top-level/all-packages.nix
Outdated
| erlangR18 erlangR18_odbc erlangR18_javac erlangR18_odbc_javac | ||
| erlangR19 erlangR19_odbc erlangR19_javac erlangR19_odbc_javac | ||
| erlangR20 erlangR20_odbc erlangR20_javac erlangR20_odbc_javac; | ||
| erlangR17 erlangR17_odbc erlangR17_javac erlangR17_odbc_javac erlangR17_nox |
There was a problem hiding this comment.
@LnL7 These lines expose plenty of Erlang versions at top level in all-packages.nix.
|
@LnL7 do you want to merge yours first and I will then rebase against master? The top-level attributes don't seem to be used anywhere in-tree. |
|
@peterhoeg I re-applied the changes, it probably got lost with a merge or something. |
|
So everybody is cool with |
Motivation for this change
Erlang pulls in a lot of X dependencies by default. This "_nox" variation reduces the size of the default R18 closure from 465mb to 306mb.
Further to #29518
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)