top-level: No gccCrossStageFinal needed anymore
#29610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
added
the
6.topic: cross-compilation
Ericson2314
changed the title
gccCrossStageFinal needed anymore
Ericson2314
force-pushed
the
no-gccCrossStageFinal
branch
from
62fb67b
to
5394f3f
Compare
8 tasks
|
Looks good to me, I suppose. I'm not too familiar with the gcc parts though. |
dezgeg
approved these changes
Sep 21, 2017
This gets us one step closer to removing `gccCrossStageFinal`. Care is taken to avoid a mass rebuild; will clean up with one later.
Unfortunately this makes previously-barely-working overrides have infinite recursion, so I had to reinstantiate gcc for gccCrossStageFinal instead.
Ericson2314
force-pushed
the
no-gccCrossStageFinal
branch
from
5394f3f
to
b9bf90c
Compare
|
Hmm, this only made @edolstra a code owner because of the one-word change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
gccCrossStageFinalhas been removed in lieu of the normalgcc*attributes, which will now work fine.The only downsides to this are
gcc.cc.overridein the definition of `gccCrossStageStatic no longer works, but that was kind of infinite-recursion-prone all along.Some contortions are needed to avoid a mass rebuild, but that can be cleaned up longer term. I rather merge this now, and send a much lighter PR to staging to do that.
Things done
No native or cross hashes changed!
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)