seafile-client: add optional Shibboleth support #29025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 5, 2017
| @@ -1,5 +1,8 @@ | |||
| { stdenv, fetchurl, writeScript, pkgconfig, cmake, qtbase, qttools | |||
| , seafile-shared, ccnet, makeWrapper }: | |||
| , seafile-shared, ccnet, makeWrapper | |||
| , withShibboleth ? false, qtwebengine }: | |||
There was a problem hiding this comment.
You can default to true, if this feature does not introduce a regression or remove the feature flag completely.
There was a problem hiding this comment.
Well I think I'll use truethen but I'll keep the option since it's also available upstream.
dotlambda
force-pushed
the
seafile-client
branch
from
132f4aa
to
7cceee2
Compare
|
ping |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is used by some universities.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)cc @Calrama