Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana: 4.3.2 -> 4.4.3 #29027

Merged
merged 1 commit into from Sep 5, 2017
Merged

grafana: 4.3.2 -> 4.4.3 #29027

merged 1 commit into from Sep 5, 2017

Conversation

WilliButz
Copy link
Member

@WilliButz WilliButz commented Sep 5, 2017 •
edited

Motivation for this change

outdated: Mostly the new ace-editor integration:
https://community.grafana.com/t/release-notes-for-grafana-v4-5-0/2573-

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested grafana with the new features on my machine
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@WilliButz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kamilchm, @offlinehacker and @fpletz to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2017

Unless there is an important bug fixed by this update, I would prefer an upgrade to 4.4.3 first.
I suppose the final version of grafana will be released soon.

@WilliButz
Copy link
Member Author

WilliButz commented Sep 5, 2017 •
edited

Alright, my intention was to get the ace integration in our master 👍
(Also I'd say that the included bug fixes are just minor ones)

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2017 •
edited

The bug fixes are also integrated in 4.4.3. You can always use packageOverrides to get newer versions.

@WilliButz WilliButz changed the title grafana: 4.3.2 -> 4.5.0-beta1 grafana: 4.3.2 -> 4.4.3 Sep 5, 2017
@WilliButz
Copy link
Member Author

@Mic92 yeah I know about the overrides but I wanted to make the autocompletion and syntax highlighting features available to everyone using the nixpkgs master. I'm already using it on my machine :)

But I see what you mean and changed the pull request to update grafana to 4.4.3.

@fpletz fpletz merged commit 333eaca into NixOS:master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WilliButz @mention-bot @Mic92 @fpletz