jenkins: fixed-output derivation to avoid rebuilds #29030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see also NixOS#27754 (comment) for motivation.
|
@Mic92 You did the same thing for my Gerrit package yesterday, this was the pattern I followed so doing the same for it. |
|
This pattern adds a second hash that needs to be updated on version bumps. How much rebuilding is "saved"? Is it worth it? |
But that hash won't correspond to upstream source hash (right?). So it becomes more difficult to verify that the source we have is the exact same source upstream provides. I think I'm -1 on this pattern. I think it's premature optimization. (At least in the form used in this PR.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also #27754 (comment) for motivation.
Things done
build-use-sandboxinnix.confon non-NixOS)nixos/tests/jenkins.nix(had to raise the timeout)nix-shell -p nox --run "nox-review wip"