CB-231: Retrieve release group data directly from db in mapping.py #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add a test which will fail before this patch is applied? |
|
This patch actually doesn't fix the sentry error 😅. It just changes the way of fetching release group info in |
|
@ferbncode What is the status of this PR? If we've opened CB-269 for the sentry error, I think this is okay to review? |
ferbncode
force-pushed
the
mapping&sentry
branch
from
262e2b1
to
5b9cc3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed way of fetching release group info in
mapping.py. Also fixes https://sentry.metabrainz.org/share/issue/342e32383839/