Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby hangs when one line is super long in require #4778

Closed
cjyclaire opened this issue Sep 5, 2017 · 3 comments
Closed

JRuby hangs when one line is super long in require #4778

cjyclaire opened this issue Sep 5, 2017 · 3 comments

Comments

@cjyclaire
Copy link

Background, aws-sdk-ruby travis jruby suit (version > 9.1.5.0) starts hanging and ends up in being killed by travis, and I cannot reproduce this at my local mac sierra environment. This can be reproduced at travis docker (ubuntu trusty), and I have already merged a PR that fixes this.

The issue is when requiring a file that has a super long line (> 2048), jruby ubuntu distribution hangs with no output.

Environment

Travis docker
Error log with installation commands.

the install command is simply:

export PURE_RUBY=1
rvm use jruby-9.1.5.0 --install --binary --fuzzy

Expected Behavior

works fine

Actual Behavior

no error trace and hangs until the process is being killed

example error log from travis: https://travis-ci.org/aws/aws-sdk-ruby/jobs/248527729

Any advice would be appreciated.

@headius
Copy link
Member

headius commented Sep 6, 2017

How peculiar! I assume you can trigger this locally. Do so and get a thread dump from the JVM (Ctrl+\ on unix terminal, Ctrl+Brk on Windows, jstack command) and provide it here.

I suspect this is getting stuck in the regular expression we use to look for encoding, frozen string, and other pragmas in comments at the top of the file. The thread dump will tell us for sure.

@enebo
Copy link
Member

enebo commented Sep 6, 2017

If it is from magic comment parsing then I suggest trying on master of jruby-9.1 branch: #4728 ... It might be fixed.

@cjyclaire
Copy link
Author

Ah that's exactly it, glad to know it's taken care of, thanks!

@enebo enebo added this to the Invalid or Duplicate milestone Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants