Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc pkgs: Reorganize dependencies ahead of #26805 #29023

Merged
merged 2 commits into from Sep 5, 2017
Merged

misc pkgs: Reorganize dependencies ahead of #26805 #29023

merged 2 commits into from Sep 5, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Sep 5, 2017 •
edited

Motivation for this change

These dependencies were improperly classified. There's no symptoms today, but when I change the propagation logic those packages would break. With this change they ought to work before and after.

Things done

The https://hydra.mayflower.de job didn't quite finish, but I consider this good enough to merge to staging. I'll retarget this branch for the 17.09 backport next, where we'll be more careful.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • So far so good https://hydra.mayflower.de/eval/1512
  • Built stdenv with downstream PR on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 added this to the 17.09 milestone Sep 5, 2017
@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Sep 5, 2017
@Ericson2314 Ericson2314 added this to Needed by the big PR---nice to move pick off pieces of it and move here, rebasing the big PR on top in Cross compilation Sep 5, 2017
@Ericson2314 Ericson2314 merged commit 40e917d into NixOS:staging Sep 5, 2017
@Ericson2314 Ericson2314 deleted the deps-reorg branch September 5, 2017 22:10
@Ericson2314 Ericson2314 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 5, 2017
@Ericson2314 Ericson2314 mentioned this pull request Sep 5, 2017
Merged
8 tasks
@Ericson2314
Copy link
Member Author

#29039 is building the stable port, among other things.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on
Projects
No open projects
Cross compilation
Needed by the big PR---nice to move p...
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @samueldr