Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary parenthesis from Cast#to_s result #4862

Merged
merged 1 commit into from Sep 20, 2017
Merged

Remove unnecessary parenthesis from Cast#to_s result #4862

merged 1 commit into from Sep 20, 2017

Conversation

makenowjust
Copy link
Contributor

Fix #4861 (comment)

pp (1 < 2).as(Bool)

# Before:
#     ((1 < 2)).as(Bool) # => true
# After:
#     (1 < 2).as(Bool) # => false

@luislavena
Copy link
Contributor

@mverzilli @bcardiff @RX14 can you review?

Thank you.

@mverzilli mverzilli added this to the Next milestone Sep 20, 2017
@mverzilli mverzilli merged commit f5abb5b into crystal-lang:master Sep 20, 2017
@mverzilli
Copy link

Thanks!

@makenowjust makenowjust deleted the fix/crystal/cast-to-s-unnecessary-paren branch September 20, 2017 04:55
@asterite asterite mentioned this pull request Sep 20, 2017
Merged
makenowjust added a commit to makenowjust/crystal that referenced this pull request Sep 27, 2017
@makenowjust
Remove unnecessary parenthesis
d27122e 
Follow crystal-lang#4862 fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mverzilli mverzilli mverzilli approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:feature
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makenowjust @luislavena @mverzilli @RX14