Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

389-ds-base: 1.3.5.17 -> 1.3.5.19 #28432

Merged
merged 1 commit into from
Aug 30, 2017
Merged

389-ds-base: 1.3.5.17 -> 1.3.5.19 #28432

merged 1 commit into from
Aug 30, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@NeQuissimus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @grahamc, @edolstra and @wkennington to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Aug 26, 2017

Is 389-ds-base a valid attribute name for a package?

nix-shell --keep-going -j10 -p 389-ds-base --show-trace
error: while evaluating the attribute _buildInputs_ of the derivation _shell_ at /home/joerg/git/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:85:11:
while evaluating _getOutput_ at /home/joerg/git/nixpkgs/lib/attrsets.nix:450:23, called from undefined position:
while evaluating anonymous function at /home/joerg/git/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:48:15, called from undefined position:
undefined variable _ds-base_ at (string):1:70

@NeQuissimus
Copy link
Member Author

I just tried if it builds and it does...

@fpletz fpletz merged commit 8397dd4 into NixOS:master Aug 30, 2017
@NeQuissimus NeQuissimus deleted the 389_ds_base_1_3_5_19 branch February 14, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NeQuissimus @mention-bot @Mic92 @fpletz