remove collection-json from dont-distribute-packages #28383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe I've fixed the build issues for collection-json and would like to see it make it into the next stable release of NixOS. I'm also adding myself as maintainer. Let me know if there is anything I did incorrectly or missed.
|
This PR breaks evaluation because there is no maintainer called |
peti
added a commit
to peti/nixpkgs
that referenced
this pull request
Aug 22, 2017
5342bff refers to an unknown Nixpkgs maintainer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I believe I've fixed the build issues for collection-json and would like
to see it make it into the next stable release of NixOS. I'm also
adding myself as maintainer.
Let me know if there is anything I did incorrectly or missed.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)