Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geogebra: 5-0-377-0 -> 5-0-382-0 #28377

Merged
merged 2 commits into from Aug 20, 2017
Merged

geogebra: 5-0-377-0 -> 5-0-382-0 #28377

merged 2 commits into from Aug 20, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 18, 2017

Motivation for this change

Updates geogebra to latest version to prevent breaks.
Furthermore it adds a fallback to web.archive.org.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Ma27, thanks for your PR! By analyzing the history of the files in this pull request, we identified @moyamo and @obadz to be potential reviewers.

@joachifm joachifm merged commit aeb733c into NixOS:master Aug 20, 2017
@Ma27 Ma27 deleted the update/geogebra branch August 20, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @mention-bot @joachifm