Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renoise: 3.0.1 -> 3.1.0 #28380

Merged
merged 1 commit into from Aug 21, 2017
Merged

renoise: 3.0.1 -> 3.1.0 #28380

merged 1 commit into from Aug 21, 2017

Conversation

seanparsons
Copy link
Contributor

Motivation for this change
  • Bump to 3.1.0.
  • Renoise non-demo builds have a licence baked into them, which means each is a totally individual bundle so SHAs can't be used.
Things done
  • Updated the version to 3.1.0.
  • Replaced the demo parameter with the releasePath parameter so that a path to the full version can be supplied.
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@seanparsons, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fps, @krgn and @dezgeg to be potential reviewers.

@seanparsons
Copy link
Contributor Author

While I remember, it would be amazing if this could be streamlined into the 17.03 branch as well.

@seanparsons
renoise: 3.0.1 -> 3.1.0
b8b1183 
Replaced demo parameter with releasePath parameter.
@the-kenny the-kenny merged commit 830d8b3 into NixOS:master Aug 21, 2017
the-kenny pushed a commit that referenced this pull request Aug 21, 2017
@seanparsons @the-kenny
renoise: 3.0.1 -> 3.1.0 (#28380)
c4abd6f 
Replaced demo parameter with releasePath parameter.
@seanparsons
Copy link
Contributor Author

@the-kenny Is the 17.03 channel frozen? The current commit for it looks to be way behind even this PR.

@the-kenny
Copy link
Contributor

@seanparsons The channel might be frozen, yeah. I personally don't use channels and can't say much on that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seanparsons @mention-bot @the-kenny @Janik-Haag