Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx-modules: remove unused fetchpatch #29494

Merged
merged 1 commit into from Sep 17, 2017
Merged

nginx-modules: remove unused fetchpatch #29494

merged 1 commit into from Sep 17, 2017

Conversation

vaibhavsagar
Copy link
Member

Motivation for this change

fetchpatch was introduced in #29393 but is not used.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vaibhavsagar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @mattbillenstein and @benley to be potential reviewers.

rnhmjoj
rnhmjoj approved these changes Sep 17, 2017
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thank you.

@joachifm joachifm merged commit d72747e into NixOS:master Sep 17, 2017
@vaibhavsagar vaibhavsagar deleted the nginx-modules branch September 17, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vaibhavsagar @mention-bot @rnhmjoj @joachifm