Biome generation: Fix layers of 'filler' nodes at biome y limits

paramat · paramat · commit 76817fdf98b1 · 2017-09-17T03:20:20.000+01:00
Error was exposed by commit a1389c3 'nplaced' was not set to U16_MAX when biome 'stone' was placed, so when biome was recalculated in a column of stone, the 'nplaced' value caused a few remaining filler nodes to be placed. Occurs when the lower biome has a deeper depth of 'top' plus 'filler' than the upper biome.
diff --git a/src/mapgen.cpp b/src/mapgen.cpp
@@ -722,6 +722,7 @@ void MapgenBasic::generateBiomes(MgStoneType *mgstone_type,
 					nplaced++;
 				} else {
 					vm->m_data[vi] = MapNode(biome->c_stone);
+					nplaced = U16_MAX;  // Disable top/filler placement
 				}
 
 				air_above = false;

Original file line number	Diff line number	Diff line change
`@@ -722,6 +722,7 @@ void MapgenBasic::generateBiomes(MgStoneType *mgstone_type,`
`722`	`722`	`nplaced++;`
`723`	`723`	`} else {`
`724`	`724`	`vm->m_data[vi] = MapNode(biome->c_stone);`
	`725`	`+ nplaced = U16_MAX; // Disable top/filler placement`
`725`	`726`	`}`
`726`	`727`
`727`	`728`	`air_above = false;`